Make revset symbol resolution async - #9910
Open
martinvonz wants to merge 2 commits into
Open
Conversation
Revset symbol resolution will soon be async, so this needs to be async too.
Symbol resolution can be customized and may involve I/O, so it should be async.
yuja
reviewed
Aug 4, 2026
| /// Transforms the `expression`. By default, inner items are transformed | ||
| /// recursively. | ||
| fn fold_expression( | ||
| async fn fold_expression( |
Contributor
There was a problem hiding this comment.
Do you have any concerns about recursion here?
It might be better to collect all referenced symbols, resolve them all at once asynchronously, and then rewrite expressions recursively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)how it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.