index: make has_id() async - #9901
Merged
Merged
Conversation
OlshaMB
force-pushed
the
push-rsvtvupnstqn
branch
from
August 2, 2026 16:16
38f0876 to
1b84155
Compare
Contributor
|
nit: "nessasary" => "necessary" in the commit message. |
OlshaMB
force-pushed
the
push-rsvtvupnstqn
branch
from
August 2, 2026 16:33
1b84155 to
62a89c0
Compare
Contributor
Author
fixed |
icorbrey
reviewed
Aug 3, 2026
icorbrey
left a comment
icorbrey
left a comment
Contributor
There was a problem hiding this comment.
Small nits re: closures, but otherwise looks good
martinvonz
reviewed
Aug 3, 2026
OlshaMB
force-pushed
the
push-rsvtvupnstqn
branch
3 times, most recently
from
August 5, 2026 08:51
2fdc35d to
22638a2
Compare
martinvonz
reviewed
Aug 11, 2026
This makes `has_id` on Index async, converts iterator where necessary to async vec. For now introduces block_on in id_prefix.rs, since converting that requires modifying revset engine.
OlshaMB
force-pushed
the
push-rsvtvupnstqn
branch
from
August 11, 2026 15:54
22638a2 to
6839805
Compare
martinvonz
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)how it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.