Skip to content

Improve French translation#140

Open
xinxinxinxinxin wants to merge 3 commits into
jithware:masterfrom
xinxinxinxinxin:master
Open

Improve French translation#140
xinxinxinxinxin wants to merge 3 commits into
jithware:masterfrom
xinxinxinxinxin:master

Conversation

@xinxinxinxinxin

Copy link
Copy Markdown

No description provided.

@jithware

Copy link
Copy Markdown
Owner

@bestlibre can you please confirm these translations are valid?

Comment thread lib/l10n/app_fr.arb
"exhaleAudio": "Son d'expiration",
"exhaleHoldAudio": "Son d'expiration bloquée",
"duration": "Durée",
"durationVibrate": "Vibration finale",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the application the parameter is for the duration of the last vibration. I think that "Durée de la vibration finale" is a little too long for the screen. I have chosen to keep "finale" and not "durée". I'm not sure of the correct choice.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Durée vibration finale" ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope the string is not too long for the UI. Do you know the limit @jithware ?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe flutter will insert "..." is some cases where a string is too long, for example in the title bar. In others it will display a black and yellow box warning in the UI when the string extends past the available area. Looking at the french screenshot, it appears as if may fit.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bestlibre I've made all the changes. Do you agree with them?

Comment thread lib/l10n/app_fr.arb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants