Classify external-data CTests for local pipeline#124
Open
krystophny wants to merge 2 commits into
Open
Conversation
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CMake tree registers 16 reconstruction tests that require separately managed templates and reference datasets. The supported local
make testtarget deliberately runs the self-contained tests underbuild/TEST, but generic CTest discovery sees both groups.This change labels the reconstruction cases
regression;external-data, keeping all 16 registered and runnable with the complete external-data workflow while allowing the default local pipeline to exercise the self-contained suite. It also removes two unused imports reported by the full lint pass.No numerical algorithm, discretization, convergence criterion, source term, generated code, ABI, memory layout, physical convention, boundary condition, or conservation law changes. Test commands and expected numerical comparisons are unchanged.
Verification
Test fails on main
All 16 failures stop in harness setup because the separately managed templates and references are unavailable; no numerical comparison is reached. The subsequent full lint pass also reports the two unused imports.
Test passes after fix
The 16 numerical regressions remain a separate unverified gate until their external datasets are supplied; this PR does not mark them passed.