Skip to content

QL: retain propagator join solver diagnostics#128

Open
krystophny wants to merge 11 commits into
mainfrom
fix/flux-pumping/join-diagnostics
Open

QL: retain propagator join solver diagnostics#128
krystophny wants to merge 11 commits into
mainfrom
fix/flux-pumping/join-diagnostics

Conversation

@krystophny

Copy link
Copy Markdown
Member

Refs #127. This child is stacked on #126, #125, #119, #121, and #124 and remains open against main.

Summary

  • report the exact DGBSV status and solve stage when intermediate propagator joining fails
  • report old/new propagator tags, matrix dimensions, and finite matrix/RHS counts
  • cover the production diagnostic with a real singular DGBSV solve

Invariants

Successful joins are unchanged. On failure, the existing stage error code and stop path remain unchanged; the change only retains diagnostics already available at the call site. It does not change the join matrix, right-hand side, pivoting, solver acceptance, discretization, convergence criteria, source weights, field-line boundary conditions, ABI, array ownership, or storage layout.

No branch in this stack is authorized to merge before the programme-wide gate.

Verification

Test fails before implementation

With only the behavioral test applied at parent 4b00b88:

$ cmake --build build --target test_join_failure_diagnostic
Fatal Error: Cannot open module file 'join_diagnostics_mod.mod'
ninja: build stopped: subcommand failed.

The parent has no production diagnostic API that can retain the LAPACK status.

Test passes after implementation

$ fo
Static: OK (333 modules)
Build: OK
Tests: OK
Lint: OK
All stages passed

$ make test
100% tests passed, 0 tests failed out of 11

$ ctest --test-dir build -R '^join_failure_diagnostic_test$' --output-on-failure
100% tests passed, 0 tests failed out of 1

$ git diff --check
<no output>

The singular 2x2 fixture returns info=2; the production diagnostic prints stage 2, status 2, both tag pairs, dimensions 2 2, and finite counts 4/4 and 2/2.

The 16 separately managed external-data regressions remain registered under regression;external-data; this branch does not mark that unavailable-data gate passed. Root-cause repair for #127 remains a separate child after a replayable join fixture identifies the failing pivot/input state.

isw_qflux_NA=1 with in_file_pert='none' assembles an identically zero
non-axisymmetric source. That zero vector is the Arnoldi seed, so its
normalization divides by zero (0/0 -> NaN) and zhseqr then fails to
converge at every step, spinning without qflux output. Reject the
configuration in check() with a clear message instead.
Add an optional right-hand side to the non-axisymmetric solve: the
drive of a single-helicity perturbation given by a radial corrugation
field (delta B^s/B_0^phi)_mn and an electrostatic potential harmonic
Phi_mn. The vpar corrugation piece enters the A1/A2 force channels
with velocity weights a3m and x^2 (sigma-odd), the ExB piece with
weights x^-1 and a1m (sigma-even); the two new velocity moments are
computed in compute_sources. Input via new &ntv_input variables
(isw_hel_drive, m_theta_hel, hel_brad_re/im, hel_phim_re/im), default
off. Band profiles, moments and dimensional prefactors follow a
CAS-checked derivation (see issue #118).

Off by default: golden-record QL summary.h5 is reproduced to 1e-15
against a main build.
Review findings on the drive commit: fold the x^(3k-4) weight into a
single power so the x=0 quadrature node stays finite; skip the moment
quadrature on the precomputed-matrix-element path and reject
isw_hel_drive at run time when the moments are unavailable; reject the
unvalidated relativistic branch, reconstruction mode and unset species
data; deallocate asource_hel in collop_unload.
The zero-source guard added upstream rejects isw_qflux_NA=1 with
in_file_pert='none'. With the misalignment drive, that configuration is
valid: the drive supplies the non-axisymmetric source. Relax the guard
so it fires only when the drive is off or all its amplitudes are zero.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant