Add CanonicalTerm, fix duplicate keys handling in map generator/validator#203
Merged
Conversation
Soupstraw
force-pushed
the
jj/term-canonical-eq
branch
from
18a0f37 to
adc80cb
Compare
Soupstraw
changed the title
CanonicalTerm, fix duplicate keys bug in map generatorCanonicalTerm, fix duplicate keys handling in map generator/validator
Soupstraw
force-pushed
the
jj/term-canonical-eq
branch
from
106adc3 to
3e6883d
Compare
Soupstraw
force-pushed
the
jj/term-canonical-eq
branch
7 times, most recently
from
0b921d2 to
b0c8837
Compare
Soupstraw
force-pushed
the
jj/term-canonical-eq
branch
from
b0c8837 to
83c7b45
Compare
Soupstraw
force-pushed
the
jj/term-canonical-eq
branch
5 times, most recently
from
1c29f4c to
b8e0229
Compare
10 tasks
neilmayhew
approved these changes
Jun 17, 2026
Soupstraw
force-pushed
the
jj/term-canonical-eq
branch
from
b8e0229 to
b2dc97a
Compare
Co-authored-by: Neil Mayhew <neil@mayhew.name>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with duplicate keys in maps. The validator now checks for duplicate keys in maps and generators will no longer produce duplicate keys. The
CanonicalTermtype has been added to handle comparisons on CBOR data correctly.