Enable Dijkstra Twiddling tests, relax some decoders in PV12#5862
Draft
Soupstraw wants to merge 17 commits into
Draft
Enable Dijkstra Twiddling tests, relax some decoders in PV12#5862Soupstraw wants to merge 17 commits into
Soupstraw wants to merge 17 commits into
Conversation
Soupstraw
changed the title
Soupstraw
force-pushed
the
jj/dijkstra-twiddling
branch
2 times, most recently
from
99a8140 to
13391db
Compare
lehins
reviewed
May 29, 2026
Soupstraw
force-pushed
the
jj/dijkstra-twiddling
branch
12 times, most recently
from
5b706a6 to
4d865f8
Compare
Soupstraw
force-pushed
the
jj/dijkstra-twiddling
branch
from
13dde78 to
1093b1c
Compare
neilmayhew
previously approved these changes
Jun 17, 2026
|
|
||
| decodeIPv4 :: Decoder s IPv4 | ||
| decodeIPv4 = | ||
| toIPv4w <$> binaryGetDecoder "decodeIPv4" getWord32le |
Contributor
There was a problem hiding this comment.
I assume Cardano has done this all along, but it looks weird to me to see IP addresses using little-endian encoding, since the TCP/IP standard has always been big-endian ("network byte order") 😁
Comment on lines
+65
to
+68
| class (Typeable a, KnownNat (Size a)) => FixedSizeBytes a where | ||
| type Size a :: Nat | ||
| rawEncode :: a -> C.Encoding | ||
| rawDeserialise :: BS.ByteString -> Maybe a |
Contributor
There was a problem hiding this comment.
Will this be removed after IntersectMBO/cardano-base#665 is merged?
Maybe you could test it with an srp for base.
Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
Soupstraw
force-pushed
the
jj/dijkstra-twiddling
branch
from
1093b1c to
14c5238
Compare
Soupstraw
force-pushed
the
jj/dijkstra-twiddling
branch
from
9edcad0 to
5ada1eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Blocked on:
input-output-hk/cuddle#204
input-output-hk/cuddle#203
IntersectMBO/cardano-base#665
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).