[17.0][FIX] stock_ux: evitar validar remitos con seriales sin asignar (#119570)#944
Closed
jcadhoc wants to merge 1 commit into
Closed
[17.0][FIX] stock_ux: evitar validar remitos con seriales sin asignar (#119570)#944jcadhoc wants to merge 1 commit into
jcadhoc wants to merge 1 commit into
Conversation
Collaborator
|
|
jcadhoc
force-pushed
the
17.0-h-119570-jc
branch
3 times, most recently
from
a016774 to
9b992d5
Compare
mav-adhoc
force-pushed
the
17.0-h-119570-jc
branch
3 times, most recently
from
86dd4ac to
44453fa
Compare
Agrega _check_serial_quantity_consistency en _sanity_check de stock.picking para que la validacion de un remito con productos trackeados por serial exija que la cantidad hecha coincida con la cantidad de seriales asignados. Odoo standard solo verifica que cada move line existente con picked=True tenga su lote/serie, pero nunca reconcilia move.quantity contra el conteo de seriales. Esto permitia remitir N unidades con menos de N seriales (ej. 5 unidades, 4 seriales), dejando un movimiento inconsistente imposible de retornar. Usa abs(move.quantity) y != 0 para manejar cantidades negativas (ajustes de inventario, devoluciones) sin falsos bloqueos. Incluye fix adicional: _check_number_of_packages cambia de return warning a raise UserError para mantener consistencia con el resto de las validaciones.
mav-adhoc
force-pushed
the
17.0-h-119570-jc
branch
from
44453fa to
a4c1ff6
Compare
Contributor
|
@roboadhoc r+ nobump |
roboadhoc
pushed a commit
that referenced
this pull request
Jun 17, 2026
Agrega _check_serial_quantity_consistency en _sanity_check de stock.picking para que la validacion de un remito con productos trackeados por serial exija que la cantidad hecha coincida con la cantidad de seriales asignados. Odoo standard solo verifica que cada move line existente con picked=True tenga su lote/serie, pero nunca reconcilia move.quantity contra el conteo de seriales. Esto permitia remitir N unidades con menos de N seriales (ej. 5 unidades, 4 seriales), dejando un movimiento inconsistente imposible de retornar. Usa abs(move.quantity) y != 0 para manejar cantidades negativas (ajustes de inventario, devoluciones) sin falsos bloqueos. Incluye fix adicional: _check_number_of_packages cambia de return warning a raise UserError para mantener consistencia con el resto de las validaciones. closes #944 Signed-off-by: Matias Velazquez <mav@adhoc.com.ar>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cambio
Agrega
_check_serial_quantity_consistency()en el_sanity_check()de
stock.pickingpara bloquear validacion de remitos donde lacantidad hecha en un producto con tracking por serial no coincida
con la cantidad de seriales asignados.
Odoo standard verifica que cada move line picked tenga su serial,
pero nunca reconcilia
move.quantitycontra la cantidad de lineascon serial. Esto permitia validar un remito con 5 unidades hechas
pero solo 4 seriales asignados, dejando un movimiento inconsistente
imposible de retornar.
Fix adicional
_check_number_of_packages()cambia dereturn {"warning": ...}a
raise UserErrorpara mantener consistencia con el resto de lasvalidaciones del modulo.
Test plan
Agregado test automatizado
test_serial_quantity_consistency.py.Refs: https://www.adhoc.inc/odoo/web#id=119570&model=helpdesk.ticket