test(get.R): add snapshot testing workflow - #126
Merged
Conversation
… to make it compatible with newer dbplyr versions
…n, DESCRIPTION and NAMESPACE
florisvdh
approved these changes
Jul 15, 2026
florisvdh
left a comment
Member
There was a problem hiding this comment.
Great!!! Thank you very much for providing a consistent testing framework that conforms with testthat & tidyverse guidelines, and for adding awesome documentation! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Introduce a testing setup for the database functions (
get_locs,get_xg3,get_chem). While running these tests, a dbplyr query translation error was discovered and subsequently fixed.Key Changes
Main goal: snapshot testing setup (
tests/testthat)Bonus: bugfix discovered during testing
get_chemwhere modern dbplyr versions generated corrupted SQL expressions by replacing the legacy rawsql()string with nativedplyr::between()syntax.