test(dwh-migration): setup test suite to validate DWH migration - #128
Merged
Conversation
florisvdh
reviewed
Jul 14, 2026
florisvdh
left a comment
Member
There was a problem hiding this comment.
Very nice work, thank you!! 👌
florisvdh
approved these changes
Jul 14, 2026
florisvdh
left a comment
Member
There was a problem hiding this comment.
🥇
Again, the target branch is yours so merging is up to you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Add a dedicated test suite designed to verify package behavior during DWH migration.
These tests target a robust static vallidation subset of locked locations (locations that are unlikely to have data changes in the future) with high observation counts to ensure that our core query pipelines (
get_locs(),get_xg3(), andget_chem()) maintain the same output over database updates.NOTE: this subset was created in collaboration with the Databeheer team (who performed the actual database migration).
Key Changes
tests/testthat/test-dwh-migration: Introduction of new testing file with tests that evaluate all functions that create database queries.test.run_dwh_migration: New toggle option to ensure the test can be isolated and ignored when unnecessary.README.me: Updated the testing documentation to guide developers on how to run these migration tests.How to run
By default, these tests are skipped. When verifying the data warehouse migration, run the following: