Set lazyLoadTabs to false by default#252
Merged
Merged
Conversation
svara
marked this pull request as ready for review
July 7, 2026 07:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the default of
HotwireTabBarController'slazyLoadTabsinitializer parameter (introduced in #250) fromtruetofalse, making lazy tab loading opt-in.Eager loading — every tab performing its initial visit when
load(_:)is called — is the behavior shipped in 1.2.2 and earlier. The lazy-by-default setting from #194/#250 was never part of a tagged release, so defaulting tofalsepreserves released behavior with no breaking changes.This also aligns the API with Android, where
lazyLoadTabsonHotwireBottomNavigationControllerdefaults tofalse(hotwired/hotwire-native-android#202) — same name, same placement, same default on both platforms.Changes
lazyLoadTabsnow defaults tofalse; passtrueto defer each tab's initial visit until the tab is first selected (the initially selected tab still loads right away):Documentation updated to reflect the eager default.
The demo app opts in to
lazyLoadTabsto exercise the behavior, matching the Android demo.