Move lazyLoadTabs from Hotwire.config to HotwireTabBarController initializer#250
Merged
Conversation
Member
Should we align that before we release 1.3? |
Contributor
Author
Yes. I mistakenly thought we defaulted to true in 1.2.2. Fixed in #252. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the
lazyLoadTabssetting fromHotwire.configto aHotwireTabBarControllerinitializer parameter.Lazy tab loading was introduced in #194 as a global config option. Since the behavior is specific to
HotwireTabBarController, it fits better as an initializer parameter than as library-wide configuration, and this aligns the API shape with Android, where hotwired/hotwire-native-android#202 exposeslazyLoadTabsas a constructor parameter onHotwireBottomNavigationController.Notes
The defaults intentionally differ between platforms: iOS defaults to true (lazy loading shipped here as the default), while Android defaults to false (eager loading was its released behavior, so lazy loading is opt-in there).