feat(date): add Format::parse() and Format::parseDateTime()#14
Merged
Conversation
Static entry points that detect pattern type (strftime/ICU/PHP date) and dispatch to the appropriate formatter's parse method. parseDateTime combines separate date and time patterns atomically, fixing AM/PM regex splitting bugs in consumers.
TDannhauer
approved these changes
May 22, 2026
TDannhauer
left a comment
TDannhauer
left a comment
Contributor
There was a problem hiding this comment.
parseDateTime() : ⚠ Fix or document PHP pattern gap
isPhpDateFormat() : ⚠ Document limitations; consider visibility
Merged
ralflang
added a commit
that referenced
this pull request
May 22, 2026
Release version 3.0.0-RC3 chore:gitignore refactor: Port to modern NLS implementation fix(format): remove PHP date() auto-detection from Format::parse() Update FormatParseTest.php Enhance isPhpDateFormat to exclude ICU shortcuts Merge pull request #14 from horde/feat/format-parse feat(date): add Format::parse() and Format::parseDateTime()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generalizes the solution needed for horde/nag#21
From a formatted date string and a format string, detect the formatter and create a
Horde\Date\Dateobject.Optionally use the
Horde\Date\Dateto create aHorde_Dateor (type compatible)Horde\Date\HordeLegacyDate