refactor(nag): delegate parseDate() to Format::parse()#23
Merged
Conversation
Replace 60-line strptime/ICU/regex parsing block with one-liner delegation to horde/Date Format::parse() and Format::parseDateTime(). Fixes AM/PM regex splitting bug and eliminates Windows strptime workaround.
TDannhauer
approved these changes
May 22, 2026
ralflang
added a commit
that referenced
this pull request
May 28, 2026
Release version 5.0.0-RC3 Refactor tasklist cache and sync list handling Refactor task retrieval logic in Sql.php fix(security): restrict unserialize allowed_classes (ZDI-20-1051) refactor: Transition to unified screen.css Remove persistPrefs() calls from tasklist methods Refactor ActiveSync task list cache handling Update Nag.php Refactor tasklist creation to include sync options Enhance addTasklist with synchronization and persistence Enhance tasklist management with sync functionality Refactor ActiveSync error handling and notifications Sync tasklist after adding it Refactor synchronization of tasklist addition Refactor sync_lists handling in task management chore: Update workflow dependency Merge pull request #23 from horde/refactor/adopt-format-parse refactor(nag): delegate parseDate() to Format::parse() Update addTasklist method documentation Merge pull request #22 from horde/fix/array_offset_access Merge pull request #21 from horde/fix/date_format Enhance validation checks in NagMethod Refactor getInfo and isValid methods for NagAlarm Add ICU date formatting support in parseDate method Merge pull request #20 from horde/refactor/multi_tasklist_usage_2 refactor: Use controllers rather than globals. Addresses #19 refactor: Replace strftime with IntlDateFormatter refactor(injector): Widen type hints from Horde_Injector to Horde_Injector|Injector style: constrain tag list icon size to 16px
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #21
Leverages horde/Date#14
Replace 60-line strptime/ICU/regex parsing block with one-liner
delegation to horde/Date Format::parse() and Format::parseDateTime().
Fixes AM/PM regex splitting bug and eliminates Windows strptime workaround.