fix(apache): align template standards

[mberlofa]

Summary

Align the Apache chart with the corrected template standards checker.

Changes:

• move the Helm test pod out of templates/tests/ into templates/test-connection.yaml
• add canonical networkPolicy.egress.extraEgress support while preserving extraRules
• update Apache NOTES sections to the numbered operational pattern
• add helm-unittest coverage for the Helm test pod and extraEgress
• update chart networking docs for the new NetworkPolicy value

Related issue: Closes #633
Site PR: helmforgedev/site#321

Validation

• node C:\devops\berlofa\github\helmforge\helmforge-ops\scripts\charts\template-standards-check.js --chart apache --json
• helm unittest charts/apache
• make standards-check CHART=apache
• make validate-chart CHART=apache
• make site-sync-check CHART=apache
• make release-check REPO=charts
• make attribution-check REPO=charts

Result: apache: FULLY VALIDATED (20 layers) including k3d behavioral validation for default and all ci/*.yaml scenarios.

Summary by CodeRabbit

• New Features

  • Added support for extending NetworkPolicy egress rules with an additional extraEgress configuration.
  • Included an example showing how to define extra egress destinations and ports.

• Documentation

  • Updated chart notes with clearer, numbered section headings.
  • Expanded NetworkPolicy guidance to cover the new egress option.

• Tests

  • Added coverage for custom egress rules and chart connection checks.

[github-actions]

Standards Check (GR-079) — PASS

Every changed chart fully passes standards-check.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR aligns the apache chart with template standards: adds an extraEgress NetworkPolicy configuration (values, template, docs, tests), renumbers NOTES.txt section headings 1–9, and adds a new test-connection Helm test suite.

Changes

Apache Chart Template Standards Alignment

Layer / File(s)	Summary
extraEgress NetworkPolicy support charts/apache/values.yaml, charts/apache/templates/networkpolicy.yaml, charts/apache/docs/networking.md, charts/apache/tests/networkpolicy_test.yaml	Adds a new extraEgress values key (keeping extraRules for backward compatibility), renders it via toYaml in the NetworkPolicy template, documents it with an example, and adds a test verifying rendered egress rules.
NOTES.txt numbered sections charts/apache/templates/NOTES.txt	Renames nine section headings to numbered format (1. Installation summary through 9. Resources).
Test-connection Helm test suite charts/apache/tests/test_connection_test.yaml	Adds a new test suite asserting Pod name, hook annotation, and healthcheck command pattern for the test-connection template.

Estimated code review effort: 2 (Simple) | ~10 minutes

Related issues: #633 (fix: align 81 charts with template standards) — this PR addresses the netpol-missing-extra-egress and notes-no-numbered-sections warnings for the apache chart.

Suggested labels: chart:apache, template-standards

Suggested reviewers: helmforge-ops maintainers

---

🐰 A rabbit hopped through egress rules and NOTES,
Numbered each heading, cast off old quotes,
extraEgress now flows through YAML so neat,
Tests stand guard where standards must meet.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR addresses the linked Apache objectives by removing templates/tests usage and adding extraEgress support.
Out of Scope Changes check	✅ Passed	The remaining edits are documentation, NOTES, and tests that support the stated standards-alignment changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is broadly aligned with the Apache chart standards-related changes, including test relocation, NetworkPolicy updates, and NOTES/doc refinements.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/apache-template-standards

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

🟢 Security Scan: apache

Framework	Score
MITRE + NSA + SOC2	93.43434%

✅ Security posture acceptable.