Skip to content

fix: specify System.Enum for clarity in GetUnderlyingType - #27

Merged
hanachiru merged 1 commit into
hanachiru:mainfrom
kochounoyume:feature/fix-GetUnderlyingType
Sep 7, 2025
Merged

fix: specify System.Enum for clarity in GetUnderlyingType#27
hanachiru merged 1 commit into
hanachiru:mainfrom
kochounoyume:feature/fix-GetUnderlyingType

Conversation

@kochounoyume

Copy link
Copy Markdown
Contributor

This pull request makes a minor update to the RapidEnumTemplate.cs file, clarifying the usage of the Enum.GetUnderlyingType method by adding the System namespace qualifier.

  • Updated the declaration of CacheUnderlyingType to use System.Enum.GetUnderlyingType instead of Enum.GetUnderlyingType for clearer namespace resolution.

This avoids the compilation errors that were occurring when defining enumerations within the Enum namespace.
(e.g.) Namespaces such as HogeProject.Domain.Enum

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @kochounoyume, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of generated C# code by resolving a potential naming conflict. By fully qualifying a method call to System.Enum.GetUnderlyingType, it ensures that the correct system-level type is referenced, preventing compilation failures in specific namespace configurations where a user-defined namespace might conflict with the Enum type.

Highlights

  • Clarify Enum.GetUnderlyingType usage: The RapidEnumTemplate.cs file was updated to explicitly use System.Enum.GetUnderlyingType instead of Enum.GetUnderlyingType. This resolves compilation issues that occur when user-defined enumerations are placed within a namespace also named Enum, preventing ambiguity and ensuring correct method resolution.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly identifies and fixes a potential compilation issue by fully qualifying Enum.GetUnderlyingType to System.Enum.GetUnderlyingType. This prevents namespace conflicts when enums are used in namespaces that could cause ambiguity. I have one suggestion to further improve the robustness of this change by using the global:: namespace alias, which is a practice already used elsewhere in the project's source generator templates.

}

private static readonly Type CacheUnderlyingType = Enum.GetUnderlyingType(typeof({{{context.EnumFullName}}}));
private static readonly Type CacheUnderlyingType = System.Enum.GetUnderlyingType(typeof({{{context.EnumFullName}}}));

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved robustness and consistency with the attribute generation templates in this project (which already use global::System.Type, for example), it's best to use the global:: namespace alias. This will prevent potential conflicts if a user has a custom type or alias named System. Using global:: ensures that the type is always resolved from the global namespace, making the generated code more resilient.

                        private static readonly Type CacheUnderlyingType = global::System.Enum.GetUnderlyingType(typeof({{{context.EnumFullName}}}));

@hanachiru

Copy link
Copy Markdown
Owner

Thank you for submitting the PR!

I should have added global:: but neglected to do so.
I agree with your assessment of the issue, so I will add global:: after merging.

@hanachiru
hanachiru merged commit 8085fb1 into hanachiru:main Sep 7, 2025
3 checks passed
@kochounoyume
kochounoyume deleted the feature/fix-GetUnderlyingType branch September 7, 2025 12:27
@hanachiru hanachiru mentioned this pull request Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants