Skip to content

fix: add global:: - #28

Merged
hanachiru merged 1 commit into
mainfrom
fix/add-global-in-rapid-enum-template
Sep 7, 2025
Merged

fix: add global::#28
hanachiru merged 1 commit into
mainfrom
fix/add-global-in-rapid-enum-template

Conversation

@hanachiru

Copy link
Copy Markdown
Owner

use the global:: namespace alias.
ref : #27 (comment)

@hanachiru hanachiru self-assigned this Sep 7, 2025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @hanachiru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the generated code by explicitly qualifying all system types with the global:: namespace alias. This change ensures that the generated code remains functional and avoids potential naming conflicts, regardless of the using directives present in the consumer's project.

Highlights

  • Code Generation Robustness: The generated code now explicitly uses the global:: namespace alias for all system types, such as System.Runtime.CompilerServices.MethodImplOptions and System.Collections.ObjectModel.ReadOnlyCollection.
  • using Directive Removal: Redundant using directives for System, System.Collections.Generic, System.Runtime.CompilerServices, and System.Collections.ObjectModel have been removed from the generated template.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@hanachiru

Copy link
Copy Markdown
Owner Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the robustness of the source generator by using the global:: namespace alias for system types within the generated code. This change effectively prevents potential naming conflicts with user-defined types. The modifications, which involve removing using directives and applying fully qualified names, are implemented correctly and consistently throughout the code generation template. Overall, this is a valuable enhancement to the generator.

@hanachiru
hanachiru merged commit 2d3ee34 into main Sep 7, 2025
6 checks passed
@hanachiru
hanachiru deleted the fix/add-global-in-rapid-enum-template branch September 7, 2025 12:39

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses a potential name collision issue in the source generator by using fully qualified type names with the global:: alias. The changes are consistent and thorough, removing using directives and updating all relevant types in the generation template. This significantly improves the robustness of the generated code. I've added one suggestion to improve maintainability by reducing code duplication in the template.

{{{context.Accessibility}}} static partial class {{{context.ClassName}}}
{
[MethodImpl(MethodImplOptions.AggressiveInlining)]
[global::System.Runtime.CompilerServices.MethodImpl(global::System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This attribute string is repeated multiple times. To improve maintainability and avoid duplication, consider defining it as a constant within the Generate method and reusing it via interpolation.

For example:

public static string Generate(RapidEnumGeneratorContext context)
{
    const string AggressiveInlining = "[global::System.Runtime.CompilerServices.MethodImpl(global::System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]";
    return $$$"""
        // ...
        {{{AggressiveInlining}}}
        public static string ToStringFast(this {{{context.EnumFullName}}} value)
        // ...
    """;
}

This would make the template cleaner and easier to modify if this attribute needs to be changed in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant