Move AudioLayout to grid#16133
Open
frederickobrien wants to merge 3 commits into
Open
Conversation
frederickobrien
added
the
maintenance
frederickobrien
force-pushed
the
move-audio-layout-to-grid
branch
from
d8a8ce0 to
7ab3d37
Compare
frederickobrien
force-pushed
the
move-audio-layout-to-grid
branch
from
bb701eb to
33da9a8
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
Bot
removed
the
run_chromatic
frederickobrien
force-pushed
the
move-audio-layout-to-grid
branch
from
44275d5 to
93243d7
Compare
frederickobrien
commented
Jun 28, 2026
| ArticleDisplay[format.display] | ||
| }Layout`} | ||
| /> | ||
| {audioData ? ( |
Contributor
Author
There was a problem hiding this comment.
Alternatively this fork could (should?) happen inside <MainMedia /> as the audio player here is just a different type of main media. As far as I can tell it's not used anywhere else.
frederickobrien
force-pushed
the
move-audio-layout-to-grid
branch
2 times, most recently
from
0bc3a39 to
76e769a
Compare
github-actions
Bot
removed
the
run_chromatic
frederickobrien
force-pushed
the
move-audio-layout-to-grid
branch
from
76e769a to
961b98a
Compare
frederickobrien
force-pushed
the
move-audio-layout-to-grid
branch
from
961b98a to
546b54a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #15428 and #16119, this absorbs AudioLayout into the grid system. I've extracted the audio player into its own component to keep things tidy.
Open question: I started implementing it but thought it was worth asking the question. Why is the body wider for video articles than for audio ones? This only occurs at the
widebreakpoint and to my mind seems needless. If we align their appearance both can be quite happily accommodated by themediagrid layout.Why?
Less code, fewer headaches, reduced existential dread.
Screenshots