Move standard article grid into its own component#16300
Open
frederickobrien wants to merge 1 commit into
Open
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
frederickobrien
added
the
maintenance
github-actions
Bot
removed
the
run_chromatic
frederickobrien
force-pushed
the
move-standard-content-grid-to-component
branch
from
4aa24ce to
9357a62
Compare
github-actions
Bot
removed
the
run_chromatic
frederickobrien
force-pushed
the
move-standard-content-grid-to-component
branch
from
9357a62 to
d380a83
Compare
frederickobrien
force-pushed
the
move-standard-content-grid-to-component
branch
from
d380a83 to
a92cc0e
Compare
frederickobrien
force-pushed
the
move-standard-content-grid-to-component
branch
from
a92cc0e to
cca684f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A spinoff from the ongoing grid refactor work (see #15428, #16133, #16251, etc.) this moves the article/content grid of StandardLayout into its own component. The thinking here is that the grid work is taking us towards a tighter forking system. Instead of this, with all the duplicate code it entails...
We're essentially moving towards this:
With that in mind I think it makes sense to extract the article/content grid into its own component. It's easier to read and will complement the shifting centre of gravity where layouts/article arrangements are concerned.