Move ShowcaseLayout to grid#16119
Merged
Merged
Conversation
frederickobrien
added
the
maintenance
github-actions
Bot
removed
the
run_chromatic
frederickobrien
force-pushed
the
move-showcase-arrangement-to-grid
branch
from
fb3f7b0 to
c4d3920
Compare
frederickobrien
force-pushed
the
move-showcase-arrangement-to-grid
branch
2 times, most recently
from
584cd06 to
69f8648
Compare
github-actions
Bot
removed
the
run_chromatic
frederickobrien
force-pushed
the
move-showcase-arrangement-to-grid
branch
from
69f8648 to
1e2088d
Compare
github-actions
Bot
removed
the
run_chromatic
JamieB-gu
approved these changes
Jun 12, 2026
frederickobrien
force-pushed
the
move-showcase-arrangement-to-grid
branch
from
1e2088d to
a5a4855
Compare
github-actions
Bot
removed
the
run_chromatic
frederickobrien
force-pushed
the
move-showcase-arrangement-to-grid
branch
from
a5a4855 to
02c2f2b
Compare
github-actions
Bot
removed
the
run_chromatic
frederickobrien
force-pushed
the
move-showcase-arrangement-to-grid
branch
from
02c2f2b to
6e7c8e0
Compare
github-actions
Bot
removed
the
run_chromatic
|
Seen on PROD (merged by @frederickobrien 10 minutes and 12 seconds ago) Please check your changes! |
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #15428, this absorbs the 'Showcase' layout into 'StandardLayout' using the newly implemented grid module refactor.
The benefits of reduced complexity and estate size here are hopefully pretty clear (and transferable to yet more layouts) though if this feels like a viable road to start going down we probably need to have larger chat around naming conventions.
My sense of it is 'layout' means the high level structure of an entire page e.g. ad slot -> masthead -> article -> ad slot -> relate content -> footer (or some such).
When we're talking about 'standard', 'showcase', 'immersive', 'media', 'audio', etc. what we're really talking about is different arrangements of elements inside the
<article>section specifically. So perhaps there's a rejig to be done where the 'layout' is actually the 'articleArrangement'.This pull request is exploring that kind of future and the changes it might require.
Screenshots