Skip to content

Add Competition atom type #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
marjisound wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add Competition atom type #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions thrift/src/main/thrift/atoms/footballcompetition.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
namespace * contentatom.footballcompetition
namespace java com.gu.contentatom.thrift.atom.footballcompetition
#@namespace scala com.gu.contentatom.thrift.atom.footballcompetition
#@namespace typescript _at_guardian.content_atom_model.footballcompetition

enum FootballCompetitionComponentType {
MATCHDAY = 0,
}


struct FootballCompetitionAtom {
1: required string competitionId,
2: required FootballCompetitionComponentType componentType,
// 3: optional FootballCompetitionComponentData data // This can be used for any specific data for future components, if needed
}

// If we ever need to have specific data fields for competition components,
// we can define them here.
/*
union FootballCompetitionComponentData {
1: MatchDayComponentData matchDayData
}
*/
5 changes: 4 additions & 1 deletion thrift/src/main/thrift/contentatom.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ include "atoms/chart.thrift"
include "atoms/audio.thrift"
include "atoms/shared.thrift"
include "atoms/emailsignup.thrift"
include "atoms/footballcompetition.thrift"

typedef string ContentAtomID

Expand All @@ -37,7 +38,8 @@ enum AtomType {
COMMONSDIVISION = 13,
CHART = 14,
AUDIO = 15,
EMAILSIGNUP = 16
EMAILSIGNUP = 16,
FOOTBALLCOMPETITION = 17
}

union AtomData {
Expand All @@ -58,6 +60,7 @@ union AtomData {
15: chart.ChartAtom chart
16: audio.AudioAtom audio
17: emailsignup.EmailSignUpAtom emailsignup
18: footballcompetition.FootballCompetitionAtom footballCompetition
}

struct ContentChangeDetails {
Expand Down
Loading