Skip to content

Add Competition atom type#220

Draft
marjisound wants to merge 1 commit into
mainfrom
add-new-atom-for-match-day
Draft

Add Competition atom type#220
marjisound wants to merge 1 commit into
mainfrom
add-new-atom-for-match-day

Conversation

@marjisound

@marjisound marjisound commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

This PR introduces a new Competition atom type to convert the Match Day interactive atom into a structured atom, laying the groundwork for other competition-related interactive atoms (knockout, group tables, etc.) to be converted into atoms in the future.

We can categorise all of these components under a single atom type: Competition.

Rationale: Every component listed below relies on a single variable: the competitionId. Based on this ID, the component dynamically calls the right endpoint to get its relevant data. Because the underlying core dependency are identical, I think consolidating them into a single atom type simplifies our architecture.

  • football atom group table
  • football atom group table full
  • football atom group table # (Replace # with the desired group's letter)
  • football atom knockout full
  • football atom knockout round thirty two
  • football atom knockout round sixteen
  • football atom knockout quarter
  • football atom knockout semi
  • football atom knockout final
  • football atom match day

@marjisound marjisound force-pushed the add-new-atom-for-match-day branch from bcbddef to a7540bf Compare June 26, 2026 13:41
@marjisound marjisound added the feature Departmental tracking: work on a new feature label Jun 26, 2026
@marjisound marjisound force-pushed the add-new-atom-for-match-day branch from a7540bf to 11ebe7f Compare June 26, 2026 15:24
gu-scala-library-release Bot added a commit that referenced this pull request Jun 29, 2026
…ublished by marjisound

marjisound published release version 11.1.0-PREVIEW.add-new-atom-for-match-day.2026-06-29T0813.11ebe7fa
using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow

Release-Version: 11.1.0-PREVIEW.add-new-atom-for-match-day.2026-06-29T0813.11ebe7fa
Release-Initiated-By: https://github.com/marjisound
Release-Workflow-Run: https://github.com/guardian/content-atom/actions/runs/28358070847
Release-Notes: #220
@gu-scala-library-release

Copy link
Copy Markdown
Contributor

@marjisound has published a preview version of this PR with release workflow run #62, based on commit 11ebe7f:

11.1.0-PREVIEW.add-new-atom-for-match-day.2026-06-29T0813.11ebe7fa

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the add-new-atom-for-match-day branch, or use the GitHub CLI command:

gh workflow run release.yml --ref add-new-atom-for-match-day

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@marjisound marjisound force-pushed the add-new-atom-for-match-day branch from 11ebe7f to 762a656 Compare June 29, 2026 08:54
gu-scala-library-release Bot added a commit that referenced this pull request Jun 29, 2026
…ublished by marjisound

marjisound published release version 12.1.0-PREVIEW.add-new-atom-for-match-day.2026-06-29T0857.762a6566
using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow

Release-Version: 12.1.0-PREVIEW.add-new-atom-for-match-day.2026-06-29T0857.762a6566
Release-Initiated-By: https://github.com/marjisound
Release-Workflow-Run: https://github.com/guardian/content-atom/actions/runs/28360413860
Release-Notes: #220
@gu-scala-library-release

Copy link
Copy Markdown
Contributor

@marjisound has published a preview version of this PR with release workflow run #63, based on commit 762a656:

12.1.0-PREVIEW.add-new-atom-for-match-day.2026-06-29T0857.762a6566

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the add-new-atom-for-match-day branch, or use the GitHub CLI command:

gh workflow run release.yml --ref add-new-atom-for-match-day

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Departmental tracking: work on a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant