Skip to content

Demo ShellCheck violation introduction #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Daniel-Lopez246 wants to merge 2 commits into from
Closed

Demo ShellCheck violation introduction #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e82ee4b
Demo: introduce ShellCheck violation
Daniel-Lopez246 Feb 20, 2026
7a4e406
Quote variable in demo_shellcheck_break function
Daniel-Lopez246 Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Backend/test/smoke_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,10 @@ test_shutdown() {
assert_contains "$calls" "ip link show wlan0"
}

test_shutdown
demo_shellcheck_break() {
local name="Sprint 7"
echo "$name"

@gemini-code-assist gemini-code-assist Bot Mar 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pull request description states that this change is intended to introduce a ShellCheck violation. However, this line is correct as the variable is double-quoted. To introduce the intended violation (SC2086), you should remove the quotes around $name.

Suggested change
echo "$name"
echo $name

}

test_shutdown
demo_shellcheck_break

@gemini-code-assist gemini-code-assist Bot Mar 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The output of demo_shellcheck_break is sent to standard output, which may clutter the test results. Since the output is not being used for any assertions, consider redirecting it to /dev/null to keep the test output clean.

Suggested change
demo_shellcheck_break
demo_shellcheck_break >/dev/null

Loading