[newchem-cpp] Move and rename LogTLinInterpScratchBuf#544
Merged
brittonsmith merged 75 commits intoMay 20, 2026
Merged
Conversation
This switches to using GRIMPL_NAMESPACE_DECL and puts all the helper function into the namespace
The result is definitely not bitwise identical, but that's not going to make tests fail (since the logic is not tested)
…e pointers to consts
This commit makes my_chemistry, primordial_cloudy_data, my_fields into pointers to const values (rather than raw pointers)
brittonsmith
merged commit 328e14e
into
grackle-project:newchem-cpp
4 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be reviewed after #535 is merged
This PR is quite simple (it has been split off from #535 to make it easier to review).
This is easiest to review commit-by-commit:
LogTLinInterpScratchBuffrominternal_types.hpptolnT_prep.hppLogTLinInterpScratchBuf->LnTLinInterpBuf