[newchem-cpp] Unify/Simplify ln(T) calculations#537
Merged
brittonsmith merged 13 commits intoMay 20, 2026
Merged
Conversation
It turns out that the value computed on CI and on my personal machine were -4031685600248.466 and -4031685600261.704. These values had a relative difference of ~ -3.3e-12, which slightly exceeded our tolerance (2e-12). Consequently, we just averaged the values
This tweak will help with the next PR in the sequence
mabruzzo
force-pushed
the
ncc/unify-LnT-calculation
branch
from
837317b to
15a359a
Compare
Contributor
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
brittonsmith
approved these changes
May 20, 2026
brittonsmith
left a comment
brittonsmith
left a comment
Contributor
There was a problem hiding this comment.
This is good to me. I'm happy if you want to increase the use of classes here for interpolation.
…le into ncc/unify-LnT-calculation
brittonsmith
merged commit e9e3a53
into
grackle-project:newchem-cpp
4 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to be reviewed after #544 has been merged
This PR unifies the ln(T) calculations between
cool1d_multi_gandlookup_cool_rates1d.lookup_cool_rates1dpreviously used undamped (independent of prior temperature values) values of ln(T). Within the context ofsolve_rate_coolthis was inconsistent with the ln(T) values used bycool1d_multi_g.I also slightly simplified code in
cool_multi_timethat pertains to the calculation of ln(T)Footnotes
This was a change that Gen made that we had previously discussed reverting. ↩