[newchem-cpp] transcribe calc_grain_size_increment_1d#464
Merged
brittonsmith merged 37 commits intoFeb 27, 2026
Merged
Conversation
Essentially, this type holds pointers to the various injection pathway fields in the order that is implicitly assumed throughout the codebase. This change helps simplify make_consistent and it will also simplify `calc_grain_size_increment_1d` (once transcribed). Longer term, I have a plan that will let use dispose of this ``InjectPathFieldPack`` type (but, we need to make a few changes before we get to that).
Introduce the start_idx and stop_idx members to the struct
Use the start_idx and stop_idx members to simplify make_consistent
…t for-loops PART 2
…t for-loops PART 3
…ize_increment_1d.hpp
mabruzzo
added
the
refactor
mabruzzo
changed the title
calc_grain_size_increment_1d
I was expecting this to cause gold-standard drift (but that doesn't seem to be the case)
mabruzzo
force-pushed
the
ncc/transcribe_calc_grain_size_increment_1d
branch
from
554e23a to
1671ee3
Compare
Collaborator
Author
|
ASIDE: I noticed that the dust-grain freefall test all systematically take slightly less time (think 0.2-0.4 seconds) than on the current HEAD of newchem-cpp. It's hard to definitively identify the source of speedup, but I think its because I cut a lot of unnecessary allocations out of this function |
ChristopherBignamini
added a commit
to ChristopherBignamini/grackle
that referenced
this pull request
Jan 18, 2026
brittonsmith
approved these changes
Feb 27, 2026
github-project-automation
Bot
moved this to Done
in New Chemistry and C++ Transcription
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be reviewed after PR #463 is merged
This PR transcribes
calc_grain_size_increment_1d. I couldn't help myself -- I cleaned up a bunch of logic (folding lots of logic that was explicitly repeated for every kind of injection pathway or for every kind of dust species into for-loops).As of this PR, there is no logic outside of the
inject_modelsubdirectory that directly references injection pathways by name. In other words, we are pretty close to being able to let users load an arbitrary set of injection pathways.