[newchem-cpp] Only load needed injection pathway data#478
Merged
brittonsmith merged 41 commits intoMar 19, 2026
Merged
Conversation
Essentially, this type holds pointers to the various injection pathway fields in the order that is implicitly assumed throughout the codebase. This change helps simplify make_consistent and it will also simplify `calc_grain_size_increment_1d` (once transcribed). Longer term, I have a plan that will let use dispose of this ``InjectPathFieldPack`` type (but, we need to make a few changes before we get to that).
Introduce the start_idx and stop_idx members to the struct
Use the start_idx and stop_idx members to simplify make_consistent
…t for-loops PART 2
…t for-loops PART 3
…ize_increment_1d.hpp
I was expecting this to cause gold-standard drift (but that doesn't seem to be the case)
Previously, if we used metal chemistry, we loaded all injection pathway data. Now we just load what we need. Relatedly, when we index into an array and each member corresponds to a distinct injection pathway, index 0 is now always valid. For context, when my_chemistry->multi_metals is 0, we would historically need to access the relvant data at the index specified by my_chemistry->metal_abundances.
…nly_load_needed_pathways
…nly_load_needed_pathways
…nly_load_needed_pathways
brittonsmith
approved these changes
Mar 19, 2026
github-project-automation
Bot
moved this to Done
in New Chemistry and C++ Transcription
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged after #464 has been merged
This PR stops loading unused injection pathway data
Previously, if we used metal chemistry, we loaded all injection pathway data. Now we just load what we need. Relatedly, when we index into an array and each member corresponds to a distinct injection pathway, index 0 is now always valid. (For context, when
my_chemistry->multi_metalsis 0, we would historically need to access the relevant data at the index specified bymy_chemistry->metal_abundances.)