[newchem-cpp] Introduce SpeciesLutFieldAdaptor#354
Merged
mabruzzo merged 6 commits intoAug 13, 2025
Merged
Conversation
mabruzzo
added
the
refactor
…n2024transcribe/SpeciesLUTFieldAdaptor
…n2024transcribe/SpeciesLUTFieldAdaptor
brittonsmith
approved these changes
Aug 13, 2025
brittonsmith
left a comment
brittonsmith
left a comment
Contributor
There was a problem hiding this comment.
I'm not sure how really to review this, but I'm happy for you to pull it in if it's necessary for future work.
github-project-automation
Bot
moved this from Awaiting Review
to Done
in New Chemistry and C++ Transcription
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was originally proposed as brittonsmith#28
This PR must be reviewed after #353 is merged
I need to come back and flesh out the description of this PR. (It will be easier to do that once future PRs that use this machinery are posted).
This consists of 3 commits and it introduces some important machinery that will be used to transcribed
step_rate_newton_raphson. I view this as a bit of temporary machinery to aide with transcription. In the longer term, I think we should be doing something a little more elegant (but similar in principle to this PR)