[newchem-cpp] initial transcription of step_rate_newton_raphson#374
Merged
brittonsmith merged 7 commits intoAug 15, 2025
Conversation
As noted in a prior commit (89ac828), `comp1` and `comp2` have historically been passed as arguments to the `cool1d_multi_g` Fortran subroutine, but it turns out that they are only used internally within `cool1d_multi_g` as local variable (the values of the arguments are immediately overwritten). This Commit: - modifies `lookup_cool_rates0d` such that `comp1` and `comp2` are no longer in the argument list. (They are still declared as local variables and passed as arguments to `cool1d_multi_g` -- modifying `cool1d_multi_g` is a task for the future) - removes `comp1` and `comp2` entirely from `step_rate_newton_raphson` - adjusts the function declarations of `step_rate_newton_raphson` and `lookup_cool_rates0d` in fortran_func_decl.h accordingly
This commit was accomplished with some search-and-replace commands within vim
…ranscribe/initial-step_rate_newton_raphson
mabruzzo
added
the
refactor
This was referenced Aug 13, 2025
mabruzzo
changed the title
step_rate_newton_raphsonstep_rate_newton_raphson
brittonsmith
approved these changes
Aug 15, 2025
github-project-automation
Bot
moved this from Awaiting Review
to Done
in New Chemistry and C++ Transcription
mabruzzo
deleted the
gen2024transcribe/initial-step_rate_newton_raphson
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was originally proposed as brittonsmith#29
This PR must be reviewed after #354 is merged
This is the initial attempt at transcribing
step_rate_newton_raphson. This is pretty bare bones and a lot of cleanup will be done in followup PRs(the goal was to make this PR relatively small and easy to review)