[newchem-cpp] Remove last occurence of logical from Fortran source files#261
Merged
brittonsmith merged 9 commits intoJun 11, 2025
Merged
Conversation
Unlike other cases where we replaced ``logical`` with ``MASK_TYPE``, I replaced it with ``integer*8`` for the sake of consistency with the grackle-project#160 PR (I plan to use the transcription of interpolators_g.F from that PR in the future).
mabruzzo
changed the title
logical from Fortran source fileslogical from Fortran source files
mabruzzo
moved this from In Progress
to Awaiting Review
in New Chemistry and C++ Transcription
mabruzzo
added
the
refactor
mabruzzo
force-pushed
the
remove-last-logical
branch
from
ba87c83 to
97f0648
Compare
Collaborator
Author
|
With this last push, I have manually re-verified that all tests pass successfully (when I use the current HEAD of newchem-cpp as the gold-standard) |
When I changed the type of `end_int` argument of ``interpolate_3Dz_g`` to use a 64-bit integer, I forgot to modify the declaration used within the InterpolationTest.Interpolate3Dz unit-test
github-project-automation
Bot
moved this from Awaiting Review
to Done
in New Chemistry and C++ Transcription
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was originally proposed as brittonsmith#16
For context: All other occurrences of
logicalwere replaced in brittonsmith#7Unlike other cases where we replaced logical with
MASK_TYPE, I replaced it withinteger*8for the sake of consistency with prior PRs where I previously proposed a transcription of theinterpolators_g.Ffile (see #160, #251).1Footnotes
In fact, I will port over Transcribe
interpolateroutines brittonsmith/grackle#38, which was the most recent iteration of this PR. ↩