Remove last occurence of logical from Fortran source files#16
Closed
mabruzzo wants to merge 26 commits into
Closed
Remove last occurence of logical from Fortran source files#16mabruzzo wants to merge 26 commits into
logical from Fortran source files#16mabruzzo wants to merge 26 commits into
Conversation
Unlike other cases where we replaced ``logical`` with ``MASK_TYPE``, I replaced it with ``integer*8`` for the sake of consistency with the grackle-project#160 PR (I plan to use the transcription of interpolators_g.F from that PR in the future).
Author
|
I have confirmed that all tests successfully pass |
Author
|
I just refreshed the file-diff view to make it easier to review this PR, now that #15 has been merged (this is actually a really tiny PR!) |
This creates problems when we specify the answer-dir as a relative path because we commonly forget to change the directory back to the starting one. This issue will become more prominent in the next commit. - there wasn't any need to change directories in test_initialisation.py - we could remove all logic relating to explicitly changing directories by passing the ``cwd`` kwarg to ``subprocess.run`` in test_get_grackle_version.py and test_models.py (while the directory is still changed by ``subprocess.run``, they always restore the original one afterwards) More importantly, this is a good practice to have!
Previously, the test_code_examples would eagerly FAIL, if pytest was invoked to run answer-tests in "compare-mode" and the answer-file could not be found for the test_code_examples (whether or not we were planning to skip the test_code_examples). This commit relocates the FAILURE check until after the logic determining whether we should skip the test_code_examples.
… that we are building sphinx docs
Fix ReadTheDocs doc CI build
…ctor Answer test refactor
1. A bug is fixed in the Fortran Bindings 2. All references have been removed about the ``GRACKLE_DATA_DIR`` env variable. An upcoming PR (grackle-project#235) is going to overhaul this machinery, but it probably won't be merged the 3.4 release
….4Tweaks Tweaks required for 3.4 release (Fortran Binding bugfix and a few removals)
…test [newchem-cpp] Temporarily Disable OpenMP tests
Author
|
Replaced by grackle-project#261 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be reviewed after #15 (there isn't any real need for this commit to build on that other one... this is mostly out of convenience/laziness -- LMK if you want me to decouple them)
Unlike other cases where we replaced
logicalwithMASK_TYPE, I replaced it withinteger*8for the sake of consistency with the grackle-project/grackle#/160 PR (I plan to use the transcription ofinterpolators_g.Ffrom that PR in the future).