Modern Version Of: Transcribe contents of interpolators_g.F from Fortran to C#251
Closed
mabruzzo wants to merge 22 commits into
Closed
Modern Version Of: Transcribe contents of interpolators_g.F from Fortran to C#251mabruzzo wants to merge 22 commits into
mabruzzo wants to merge 22 commits into
Conversation
…eger*8 Previously end_int was a logical. This produced issues while trying to port calc_temp1d_cloudy_g to C. It's unclear whether integer*8 is the best type, but it's a place to start
…test. The transcribed routines are not currently called within the main Grackle library
- remove last reference to gr_dint (it's equivalent to gr_int) - include the relevant header - add file heading
…ch about performance in this case)
… into interpolators_modern
…n of the interpolation routines.
This was referenced Feb 20, 2025
Collaborator
Author
|
Superseded by #384 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
As noted down below, this PR should probably not reviewed
Essentially, this is a reissue of PR #160 that includes all of the more recent commits and the changes from #243.
The main change from #160 is that the tests of the C implementation are now run through the Google Test framework (introduced in #243). (I also modified the existing google tests so that they test the C implementation).
None of the actually transcribed code has actually changed from #160.
As I already mentioned, the goal isn't actually to merge this into the main branch. Currently efforts are underway to transcribe the gen2024 branch and merge these changes in as we go (before we ultimately merge the gen2024 branch).
I am making this PR as a means to run the pytest testsuite (the googletest test-suite definitely passes) and so we can keep track of already ported C routines that we won't be porting a second time.