This repository was archived by the owner on Jul 24, 2023. It is now read-only.
Front-end IngredientInput#94
Open
tgomezzzz wants to merge 15 commits into
Open
Conversation
…ns/step20-2020 into create-recipe-images
tgomezzzz
requested review from
Rmoneygit and
angplee
and removed request for
Rmoneygit
August 2, 2020 17:30
Rmoneygit
approved these changes
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new custom element that holds inputs for ingredient amounts and units. The new element, IngredientInput, extends the element ParameterInput so that ingredients still have all the functionality of a ParameterInput. The PR also adds hard-coded units and scale factors to convert from unit to unit, which will be used later to allow conversions.