This repository was archived by the owner on Jul 24, 2023. It is now read-only.
Update servlets to handle IngredientInput#95
Open
tgomezzzz wants to merge 13 commits into
Open
Conversation
…ns/step20-2020 into create-recipe-images
angplee
approved these changes
Aug 2, 2020
Rmoneygit
approved these changes
Aug 5, 2020
adamtcohen
approved these changes
Aug 7, 2020
| public Recipe(Entity recipeEntity) { | ||
| this.name = (String) recipeEntity.getProperty("name"); | ||
| this.description = (String) recipeEntity.getProperty("description"); | ||
| this.time = (double) recipeEntity.getProperty("time"); |
There was a problem hiding this comment.
do any of the other constructors also need these fields?
For the future: we should have used constructor chaining here, but don't worry about it now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To accommodate the IngredientInput element added in #94, this PR changes NewRecipeServlet's doPost() method to handle the new amount and unit fields of an IngredientInput.