-
Notifications
You must be signed in to change notification settings - Fork 237
modules/zstd: Add support for decoding compressed blocks #1857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
798f025
b1c1c66
15f470b
fe796b5
1343512
76d39b1
fdc9669
17623c1
bbcf137
206015f
819db63
e2d3edc
777766a
492b3df
864a4cd
9c7f153
ca7f230
3a429fd
f3b0f12
2e79c0b
41d33be
45b322c
3aa9989
277779c
de2925e
93e73f9
80b2f50
1634da1
416d7bc
5a3f3ff
4970bbc
8a715b2
b7109e4
2e5a3a4
90abe30
194735c
2155016
93e4d3a
0c15d13
cbc4108
30df36b
18a1b51
2ee543c
27999c7
8ac5850
226d369
647ca6d
a59a054
21e0701
c138436
abba1aa
09ac3c6
6425a25
7df49a0
8dffcb6
8fbc820
f990191
6894e2d
34d2e61
859c537
5d216db
12ff5f8
de7552c
0e1ec33
a9c9a75
19cc373
958b9b3
19a976c
e9aaa7d
71907ba
2961838
c41c2d7
446c3c8
dfaa644
dc762c1
5c56b09
5fb14e8
dd6ad64
62506a9
d0d7ae6
7c408f6
9e3ef72
b04da50
5dafdcc
bcd4197
0729939
e0995ba
ab22006
4fdf087
35c9ee5
bd17168
7f2218f
0d4cb1b
fb5686d
9678e28
760ac01
a59c71c
2d2ce54
2519c21
aadd59e
437dbc7
8b23ebd
6836389
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,11 @@ pyyaml==6.0.1 | |
| # We build most of z3 ourselves but building python is really complicated. Just | ||
| # use pypi version | ||
| z3-solver==4.14.0.0 | ||
| pytest==8.2.2 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Internally this is on 8.0.2 |
||
| cocotb==1.9.0 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI, internally we are on |
||
| cocotbext-axi==0.1.24 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this is available in our internal repository, so it would be better to untie this dependency for now and remove the associated script from the PR and import them separately. |
||
| cocotb_bus==0.2.1 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, this is not available yet internally and will need to be imported separately. |
||
| zstandard==0.23.0 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. q: does this need to be in sync w/ the C++ dep?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since we dropped the C++ tests for the ZSTD Decoder I believe those don't have to be in sync
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI, internally this is on |
||
|
|
||
| # Note: numpy and scipy version availability seems to differ between Ubuntu | ||
| # versions that we want to support (e.g. 18.04 vs 20.04), so we accept a | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you also want to consider running https://google.github.io/xls/bazel_rules_macros/#xls_dslx_fmt_test to enforce DSLX formatting as part of the CI.