Skip to content

Recognise Bind and Inject as prefixes for annotations that we should treat as injecty ones. #5265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Oct 9, 2025
Merged

Recognise Bind and Inject as prefixes for annotations that we should treat as injecty ones. #5265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions core/src/main/java/com/google/errorprone/bugpatterns/UnnecessaryQualifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,13 @@ public Description matchVariable(VariableTree tree, VisitorState state) {
var symbol = getSymbol(tree);
switch (symbol.getKind()) {
case FIELD -> {
if (INJECTION_FIELDS.stream().anyMatch(ip -> hasAnnotation(tree, ip, state))) {
if (INJECTION_FIELDS.stream().anyMatch(ip -> hasAnnotation(tree, ip, state))
|| tree.getModifiers().getAnnotations().stream()
.anyMatch(
anno ->
INJECTION_PREFIXES.stream()
.anyMatch(
p -> getSymbol(anno).getSimpleName().toString().startsWith(p)))) {

@Stephan202 Stephan202 Oct 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getSymbol(anno).getSimpleName().toString() is loop-invariant and can be moved to the outer lambda expression.

return NO_MATCH;
}
if (isRecord(symbol)) {
Expand Down Expand Up @@ -222,22 +228,12 @@ private static ImmutableList<AnnotationTree> getQualifiers(
private static final ImmutableSet<String> INJECTION_FIELDS =
ImmutableSet.of(
// keep-sorted start
"com.google.inject.Inject",
"dagger.Binds",
"dagger.BindsInstance",
"dagger.hilt.android.testing.BindElementsIntoSet",
"dagger.hilt.android.testing.BindValue",
"dagger.hilt.android.testing.BindValueIntoMap",
"dagger.hilt.android.testing.BindValueIntoSet",
"dagger.hilt.testing.BindElementsIntoSet",
"dagger.hilt.testing.BindValue",
"dagger.hilt.testing.BindValueIntoMap",
"dagger.hilt.testing.BindValueIntoSet",
"jakarta.inject.Inject",
"javax.inject.Inject"
// keep-sorted end
);

/** Prefixes for annotations on variables which can have qualifiers. */
private static final ImmutableSet<String> INJECTION_PREFIXES = ImmutableSet.of("Bind", "Inject");

private static final ImmutableSet<String> CLASS_ANNOTATIONS_EXEMPTING_METHODS =
ImmutableSet.of(
// keep-sorted start
Expand Down
Loading