Recognise Bind and Inject as prefixes for annotations that we should treat as injecty ones.#5265
Merged
Merged
Conversation
…uld treat as injecty ones. Obviously this _could_ lead to false negatives, but these are such common prefixes for injection annotations that it saves us special casing a bunch. PiperOrigin-RevId: 817162404
copybara-service
Bot
force-pushed
the
test_817102963
branch
from
October 9, 2025 13:44
16d9b10 to
144b5b1
Compare
Stephan202
reviewed
Oct 10, 2025
Stephan202
left a comment
Stephan202
left a comment
Contributor
There was a problem hiding this comment.
Just something I noticed.
| anno -> | ||
| INJECTION_PREFIXES.stream() | ||
| .anyMatch( | ||
| p -> getSymbol(anno).getSimpleName().toString().startsWith(p)))) { |
Contributor
There was a problem hiding this comment.
getSymbol(anno).getSimpleName().toString() is loop-invariant and can be moved to the outer lambda expression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognise
BindandInjectas prefixes for annotations that we should treat as injecty ones.Obviously this could lead to false negatives, but these are such common prefixes for injection annotations that it saves us special casing a bunch.