Skip to content

Fix typo in end_of_episode_behavior error messages #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
irhyl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typo in end_of_episode_behavior error messages #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion acme/adders/reverb/sequence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def __init__(
elif isinstance(end_of_episode_behavior, EndBehavior):
self._end_of_episode_behavior = end_of_episode_behavior
else:
raise ValueError('end_of_episod_behavior must be an instance of '
raise ValueError('end_of_episode_behavior must be an instance of '
f'EndBehavior, received {end_of_episode_behavior}.')

def reset(self): # pytype: disable=signature-mismatch # overriding-parameter-count-checks
Expand Down
4 changes: 2 additions & 2 deletions acme/adders/reverb/structured.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ def create_sequence_config(

Raises:
ValueError: If sequence_length is <= 0.
NotImplementedError: If `end_of_episod_behavior` is `ZERO_PAD`.
NotImplementedError: If `end_of_episode_behavior` is `ZERO_PAD`.
"""
if sequence_length <= 0:
raise ValueError(f'sequence_length must be > 0 but got {sequence_length}.')
Expand Down Expand Up @@ -359,7 +359,7 @@ def _sequence_pattern(n: int) -> sw.Pattern:
end_of_episode_configs.append(config)
else:
raise ValueError(
f'Unexpected `end_of_episod_behavior`: {end_of_episode_behavior}'
f'Unexpected `end_of_episode_behavior`: {end_of_episode_behavior}'
)

return [base_config] + end_of_episode_configs
Expand Down