Skip to content

Fix typo in end_of_episode_behavior error messages#371

Open
irhyl wants to merge 1 commit into
google-deepmind:masterfrom
irhyl:fix-end-of-episode-typo
Open

Fix typo in end_of_episode_behavior error messages#371
irhyl wants to merge 1 commit into
google-deepmind:masterfrom
irhyl:fix-end-of-episode-typo

Conversation

@irhyl

@irhyl irhyl commented Jun 29, 2026

Copy link
Copy Markdown

The parameter name end_of_episode_behavior was misspelled as end_of_episod_behavior (missing the final 'e') in three error message strings across two files.

  • acme/adders/reverb/sequence.py: ValueError when end_of_episode_behavior is not an EndBehavior instance
  • acme/adders/reverb/structured.py: docstring Raises entry for create_sequence_config, and the ValueError for unexpected enum values

These show up directly in tracebacks so the inconsistency between the parameter name and the error text is confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant