Skip to content

fix: Flaky test for Report Subcontracted Raw materials to be transferred - #26043

Merged
marination merged 1 commit into
frappe:version-13-hotfixfrom
marination:subcontracted-rm-transfer-report-test
Jun 14, 2021
Merged

fix: Flaky test for Report Subcontracted Raw materials to be transferred#26043
marination merged 1 commit into
frappe:version-13-hotfixfrom
marination:subcontracted-rm-transfer-report-test

Conversation

@marination

@marination marination commented Jun 14, 2021

Copy link
Copy Markdown
Contributor

Due to #26011

Issue:

  • test for Report Subcontracted Raw materials to be transferred randomly failed purely due to ordering of rows in supplied items table
  • In PO the supplied items table sometimes had Item 1 then Item 2 and sometimes vice versa, due to which allotting a definite transfer qty was not happening
  • While getting data from the report too, the order of item rows was flaky

Fixed:

  • Created a transfer qty map that makes sure that 1 qty is transferred against Item 1 irrespective of which row it is on
  • Alphabetically sorted Report data returned, to be certain of asserting value

@marination
marination merged commit 18833b5 into frappe:version-13-hotfix Jun 14, 2021
@frappe frappe locked as resolved and limited conversation to collaborators Mar 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant