Skip to content

feat: E-commerce Refactor - #24603

Merged
surajshetty3416 merged 106 commits into
frappe:version-13-hotfixfrom
marination:e-commerce-refactor
Sep 3, 2021
Merged

feat: E-commerce Refactor#24603
surajshetty3416 merged 106 commits into
frappe:version-13-hotfixfrom
marination:e-commerce-refactor

Conversation

@marination

@marination marination commented Feb 10, 2021

Copy link
Copy Markdown
Contributor
  • Create Website Item to handle all Website Related Data
  • Publish Item from Item Master (create Website Item)
  • Consolidated E-commerce Settings (replace Products and Shopping Cart Settings)
  • Drive Portal via Website Item and E Commerce Settings only (cleanup item and make stuff obsolete)
  • Patch for: Items ➡️ Website Items (needs load testing)
  • Patch: Shopping Cart & Products Settings ➡️ E Commerce Settings
  • Patch: Homepage Products :- Items ➡️ Website Items
  • Fix Tests

  • All Categories page (configurable)
  • Wishlist/Add to Cart (Card Actions)
  • Wishlist Full Page
  • Item Full Page (better arrangement of info, add to wishlist)
  • Ratings and Reviews
  • Capturing discounts
  • Shopping Cart Page (remove items in a click and bug fixes)
  • Grid and List view Toggling (Listing Page)
  • Search
  • Server side Test cases
  • Review changes

Redisearch Docs: frappe/erpnext_documentation#375
Official Documentation

Unofficial E-commerce guide

@marination marination added the WIP label Feb 23, 2021
@marination
marination marked this pull request as ready for review February 23, 2021 08:40
@marination marination changed the title feat: E-commerce Refactor feat: (WIP) E-commerce Refactor Feb 23, 2021
@mujeerhashmi

Copy link
Copy Markdown
Contributor

Recommendation:
Qty, Item Attributes (Size, Colour) selection should be on the product page itself above Add to Cart unlike the present pop-up for item attribute selection.

@marination

Copy link
Copy Markdown
Contributor Author

Screenshot 2021-02-25 at 1 51 28 PM

- Created "Website Item" to handle website related information
- Publishing Item new flow
- Created "E Commerce Settings"
- Removed Products Settings
- Removed Shopping Cart Settings
- Portal fully driven via E Commerce Settings
- All Item listing querying will happen via ProductQuery engine only
- Product Listing via Website Items
- removed redundant code
- Moved all website logic from Item to Website Item
- Removed old onboarding slide json and `create_onboarding_docs` methods
- Removed website sections from Item master
- Removed references to item website fields
- Shifted Item doctype website methods to Website Item
- Removed WebsiteGenerator from Item doctype
- Website Items in Homepage Products section
- Removed redundant code from item_group.py
- Fix: Item field filters won’t appear in website
…ce Settings

- Hide Attribute filters if 'Hide Variants' is enabled in E Commerce Settings
- Consider 'Hide Variants' in ProductQuery Engine
- Added docstrings
- Remove `get_e_commerce_settings`, redundant
- Patch to make website item from item
- Patch to move Products and Shopping Cart Settings into E Commerce Settings
- Patch to move products in Homepage from Item to Website Item
- Minor cleanup, replacing/removing references to Item website fields (obsolete)
- Moved all files and web templates from Shopping Cart to E-commerce module
- Made Shopping Cart module obsolete
- Moved select E-commerce related files from Portal to E-commerce module
- Minor cleanups
- Fixed Shopping Cart and Product Configurator tests
- Added Shop by Category Page
- Tabbed sections for item fields in Shop by Category Page
- Added Shop by Category Section in E commerce Settings
- Nested Navigation & Breadcrumbs in Item group pages
- Added scrollable & clickable Sub categories in Item Group page
- Made breadcrumbs slightly dynamic in Item Page
- Added image to Brand doctype
- Rough UI for card actions
- Wishlist doctype
- Indicators on card based on stock availability
@marination
marination force-pushed the e-commerce-refactor branch from 6121544 to fc40b57 Compare March 11, 2021 16:13
- Increased qty in cart on clicking add to cart for existing item
- Simplified macro arguments
- Navbar cart icon animation
- Explore button for template item in card
- Add to cart button animation
- Add remove items from wishlist
- Wishlist icon at nav bar
- Animate wishlist icon in card and navbar
- Remember wished state after refresh as well
@marination marination removed the needs-tests This PR needs automated unit-tests. label Aug 25, 2021
- Incorrect path and Settings in price_list.py import due to merge
- Extra space removed in website_item.py
- Changed client side namespace to `erpnext.e_commerce.*`
@marination
marination force-pushed the e-commerce-refactor branch from f83cd88 to d370294 Compare August 26, 2021 15:28
- Added bg (variable) to pages, card space separation visible
- Removed `show brand line` in settings, shown by default
- Re-arranged settings by importance
- View toggling primary colour is grey
- Only populate recent searches on successful search
- Hit only one server side api, once while searching
- List view primary button float right
- Discounts takes upper limit eg. 10% and below
- Navbar icons only wiggle on qty increase in cart/wishlist
- Pay button in SO portal
- Remove bottom white space below item full page image, min-height fits to content
- List view vertical space between heading and item code
- Empty offer subtitle handled
- Checkbox in website item to indicate if item is on backorder
- Indicator on listing on full page if availbale on backorder.
- fix: Allow provision to add any valid field from Website Item in Search Index
- fix: Settings filter fields are as per Item, make as per Website Item
- "Add to quote/ Go to Quote" if cart checkout is disabled
- Use simple function import instead of global variable to check if field is valid to index
- Commit after every 20 items in patch to  create web items from items
@marination marination added the CI-failing Unit tests or patch tests are failing. label Sep 3, 2021
@marination
marination force-pushed the e-commerce-refactor branch 4 times, most recently from a2b9c48 to 97bb28a Compare September 3, 2021 07:55
@marination marination removed the CI-failing Unit tests or patch tests are failing. label Sep 3, 2021
@surajshetty3416
surajshetty3416 merged commit 5138224 into frappe:version-13-hotfix Sep 3, 2021
@sagarvora sagarvora added the backport develop instructs mergify to frontport PR to develop branch label Sep 16, 2021
@frappe-pr-bot

This comment has been minimized.

@mergify

This comment has been minimized.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport develop instructs mergify to frontport PR to develop branch needs-docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.