feat: add total_billing_hours to Sales Invoice (fp #26783) - #27742
Merged
Conversation
sagarvora
requested review from
ankush,
deepeshgarg007,
nextchamp-saqib,
pateljannat,
ruchamahabal and
surajshetty3416
as code owners
October 2, 2021 07:20
sagarvora
marked this pull request as draft
October 2, 2021 07:20
sagarvora
force-pushed
the
si_total_billing_hours
branch
from
October 2, 2021 07:32
5496ea1 to
9cfd1fd
Compare
sagarvora
requested review from
nabinhait
and removed request for
ankush,
deepeshgarg007,
nextchamp-saqib,
pateljannat and
surajshetty3416
October 2, 2021 07:54
sagarvora
marked this pull request as ready for review
October 2, 2021 07:54
sagarvora
force-pushed
the
si_total_billing_hours
branch
from
October 2, 2021 08:02
1ff4eda to
1644489
Compare
sagarvora
changed the title
total_billing_hours to Sales Invoicetotal_billing_hours to Sales Invoice (fp #26783)
Collaborator
Author
|
@nabinhait Let's not accept PRs directly into |
Codecov Report
@@ Coverage Diff @@
## develop #27742 +/- ##
===========================================
+ Coverage 54.54% 54.66% +0.11%
===========================================
Files 1248 1343 +95
Lines 67517 71049 +3532
===========================================
+ Hits 36830 38837 +2007
- Misses 30687 32212 +1525
|
sagarvora
force-pushed
the
si_total_billing_hours
branch
from
October 3, 2021 08:14
4e785b9 to
3885acc
Compare
sagarvora
force-pushed
the
si_total_billing_hours
branch
from
October 4, 2021 11:10
3885acc to
711d1ff
Compare
frappe-pr-bot
pushed a commit
to frappe-pr-bot/erpnext
that referenced
this pull request
Oct 4, 2021
…rappe#27742) * feat: add `total_billing_hours` to Sales Invoice * fix: re-save doctypes * fix: indentation * fix: replace reference to old function (cherry picked from commit 09ccdee) # Conflicts: # erpnext/accounts/doctype/sales_invoice/sales_invoice.js # erpnext/accounts/doctype/sales_invoice_timesheet/sales_invoice_timesheet.json # erpnext/projects/doctype/timesheet/timesheet.py
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…rappe#27742) * feat: add `total_billing_hours` to Sales Invoice * fix: re-save doctypes * fix: indentation * fix: replace reference to old function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
total_billing_hoursto Sales Invoice #26783column_break_5)To be backported again for consistency between branches and applying fixes 😅