Skip to content

ci(release): guard helm chart tag against non-semver mutable tag #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivan-flamingo merged 3 commits into from
Jul 9, 2026
+4 −6
Merged

ci(release): guard helm chart tag against non-semver mutable tag #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f55f2eb
ci(release): guard helm chart tag against non-semver mutable tag
yaroslavmokflmg Jul 8, 2026
77509fb
ci(release): resolve latest via releases/latest API, fail on non-semver
yaroslavmokflmg Jul 8, 2026
4e241e2
ci(release): restore release job on partial builds, resolve latest vi…
yaroslavmokflmg Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ jobs:
with:
name: meshcentral
repository: ${{ github.repository }}/helm-charts
tag: ${{ needs.version.outputs.version }}
tag: ${{ needs.version.outputs.version == 'latest' && '9.9.9' || needs.version.outputs.version }}
path: ./charts/meshcentral
registry: ${{ env.REGISTRY }}
registry_username: ${{ github.actor }}
Expand All @@ -154,6 +154,7 @@ jobs:
release:
name: "Create Release"
needs: [version, build, build_helm]
if: ${{ !failure() && !cancelled() }}
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,8 @@ jobs:
run: |
set -euo pipefail

# Releases, not git tags: upstream's inherited bare tags and the 9.9.x sentinel outrank the real line under sort -V
latest=$(gh release list --limit 100 --exclude-drafts --exclude-pre-releases \
--json tagName --jq '.[].tagName' \
| grep -E '^[0-9]+\.[0-9]+\.[0-9]+$' | grep -v '^9\.9\.' | sort -V | tail -1 || true)
latest=${latest:-0.0.0}
latest=$(gh api "repos/$GITHUB_REPOSITORY/releases/latest" --jq .tag_name)
[[ "$latest" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]] || { echo "Latest release tag '${latest}' is not x.y.z"; exit 1; }
IFS='.' read -r cur_major cur_minor cur_patch <<< "$latest"

if [ -z "$INPUT_VERSION" ]; then
Expand Down
Loading