Skip to content

ci(release): guard helm chart tag against non-semver mutable tag#50

Merged
ivan-flamingo merged 3 commits into
masterfrom
hotfix/helm-tag-guard
Jul 9, 2026
Merged

ci(release): guard helm chart tag against non-semver mutable tag#50
ivan-flamingo merged 3 commits into
masterfrom
hotfix/helm-tag-guard

Conversation

@yaroslavmokflmg

@yaroslavmokflmg yaroslavmokflmg commented Jul 8, 2026

Copy link
Copy Markdown

On push, version resolves to a mutable tag (latest/dev) which is not valid OCI semver for the helm chart releaser. Same guard as fleetmdm Ylianst#71: use 9.9.9 placeholder when version is the mutable tag, otherwise the real version. build_helm only stays green today because it's skipped when the chart is unchanged; a push that changes the chart would otherwise fail the helm release.

Summary by CodeRabbit

  • Chores
    • Updated release/version handling to use the latest published release as the version source.
    • Improved fallback behavior during chart publishing when the version is marked as latest.
    • Tightened version validation to ensure release tags follow standard semantic version format.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@yaroslavmokflmg, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 29 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2efe07d1-9cdb-47f1-b114-882806b169cd

📥 Commits

Reviewing files that changed from the base of the PR and between 77509fb and 4e241e2.

📒 Files selected for processing (1)
  • .github/workflows/release.yml
📝 Walkthrough

Walkthrough

Modifies CI workflow logic for release versioning: version.yml now resolves the latest release tag via GitHub's releases/latest API endpoint with x.y.z regex validation, replacing prior multi-release filtering/sorting logic; release.yml maps a 'latest' resolved version to '9.9.9' for the Helm chart tag instead of using 'latest' directly.

Changes

Release version tagging

Layer / File(s) Summary
Version resolution and Helm tag mapping
.github/workflows/version.yml, .github/workflows/release.yml
Dispatch version resolution now calls the GitHub releases/latest endpoint and validates the tag against an x.y.z regex, replacing prior filtering/sorting logic; Helm chart releaser tag maps a 'latest' version to '9.9.9' instead of using 'latest' directly.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • flamingo-stack/meshcentral#48: Overlaps with changes to Helm chart tag wiring using needs.version.outputs.version and related version.yml version-resolution logic.

Suggested reviewers: ivan-flamingo

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main change: guarding the Helm chart tag from mutable non-semver values.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hotfix/helm-tag-guard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yaroslavmokflmg yaroslavmokflmg self-assigned this Jul 8, 2026
@ivan-flamingo ivan-flamingo merged commit 46eb1b5 into master Jul 9, 2026
5 checks passed
@ivan-flamingo ivan-flamingo deleted the hotfix/helm-tag-guard branch July 9, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants