refactor: resolve @typescript-eslint/no-this-alias warnings

eslint.config.mjs

@@ -60,7 +60,6 @@ export default [
   {
     files: ["**/*.js"],
     rules: {
-      "@typescript-eslint/no-this-alias": "warn", // TODO(bkendall): remove allow to error.
       "@typescript-eslint/no-unsafe-argument": "warn", // TODO(bkendall): remove allow to error.
       "@typescript-eslint/no-unsafe-assignment": "warn", // TODO(bkendall): remove allow to error.
       "@typescript-eslint/no-unsafe-call": "warn", // TODO(bkendall): remove allow to error.

src/activator.js

@@ -19,8 +19,8 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
 const middleware = require("./middleware");
 const promiseback = require("./utils/promiseback");
 
 const Activator = function (spec, provider) {
   this.spec = spec;
@@ -37,8 +37,6 @@
 };
 
 Activator.prototype.buildStack = function () {
-  const self = this;
-
   const stack = this.spec.stack.slice(0);
   Object.entries(this.spec.before ?? {}).forEach(([name, wares]) => {
     stack.splice(...[stack.indexOf(name), 0].concat(wares));
@@ -49,19 +47,17 @@
   });
 
   return stack.map((ware) => {
-    return typeof ware === "function" ? ware : middleware[ware](self.spec);
+    return typeof ware === "function" ? ware : middleware[ware](this.spec);
   });
 };
 
 Activator.prototype.build = function () {
-  const self = this;
-
-  return function (req, res, next) {
-    promiseback(self.awaitConfig, 2)(req, res).then((config) => {
+  return (req, res, next) => {
+    promiseback(this.awaitConfig, 2)(req, res).then((config) => {
       req.superstatic = config ?? {};
 
-      const stack = self.stack.slice(0).reverse();
-      const _run = function () {
+      const stack = this.stack.slice(0).reverse();
+      const _run = () => {
         if (!stack.length) {
           return next();
         }

src/responder.js

@@ -58,7 +58,6 @@ Responder.prototype.isNotModified = function (stats) {
 };
 
 Responder.prototype.handle = function (item, next) {
-  const self = this;
   return this._handle(item)
     .then((responded) => {
       if (!responded && next) {
@@ -67,7 +66,7 @@ Responder.prototype.handle = function (item, next) {
       return responded;
     })
     .catch((err) => {
-      return self.handleError(err);
+      return this.handleError(err);
     });
 };
 
@@ -104,34 +103,30 @@ Responder.prototype.handleError = function (err) {
 };
 
 Responder.prototype.handleStack = function (stack) {
-  const self = this;
   if (stack.length) {
     return this._handle(stack.shift()).then((responded) => {
-      return responded ? true : self.handleStack(stack);
+      return responded ? true : this.handleStack(stack);
     });
   }
 
   return Promise.resolve(false);
 };
 
 Responder.prototype.handleFile = function (file) {
-  const self = this;
   return this.provider(this.req, file.file).then((result) => {
     if (!result) {
       return false;
     }
 
-    if (self.isNotModified(result)) {
-      return self.handleNotModified(result);
+    if (this.isNotModified(result)) {
+      return this.handleNotModified(result);
     }
 
-    return self.handleFileStream(file, result);
+    return this.handleFileStream(file, result);
   });
 };
 
 Responder.prototype.handleFileStream = function (file, result) {
-  const self = this;
-
   this.streamedFile = file;
   this.res.statusCode = file.status ?? 200;
   if (this.res.statusCode === 200 && file.file === this.config.errorPage) {
@@ -156,10 +151,10 @@ Responder.prototype.handleFileStream = function (file, result) {
 
   if (this.compressor) {
     this.compressor(this.req, this.res, () => {
-      result.stream.pipe(self.res);
+      result.stream.pipe(this.res);
     });
   } else {
-    result.stream.pipe(self.res);
+    result.stream.pipe(this.res);
   }
 
   return awaitFinished(this.res).then(() => {
@@ -186,24 +181,22 @@ Responder.prototype.handleRedirect = function (redirect) {
 };
 
 Responder.prototype.handleMiddleware = function (middleware) {
-  const self = this;
   return new Promise((resolve) => {
-    middleware(self.req, self.res, () => {
+    middleware(this.req, this.res, () => {
       resolve(false);
     });
   });
 };
 
 Responder.prototype.handleRewrite = function (item) {
-  const self = this;
   if (item.rewrite.destination) {
-    return self.handleFile({ file: item.rewrite.destination });
+    return this.handleFile({ file: item.rewrite.destination });
   }
 
   for (const key in this.rewriters) {
     if (item.rewrite[key]) {
       return this.rewriters[key](item.rewrite, this).then((result) => {
-        return self._handle(result);
+        return this._handle(result);
       });
     }
   }