refactor: resolve @typescript-eslint/no-this-alias warnings#549
Merged
Conversation
Converts methods and callbacks in activator.js and responder.js to arrow functions to preserve lexical this scoping, resolving all occurrences of no-this-alias (const self = this) across the codebase.
Removes the rule override from the eslint configuration to allow the rule to default to error, preventing future regressions.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the @typescript-eslint/no-this-alias warning rule from the ESLint configuration and refactors src/activator.js and src/responder.js to eliminate the use of self = this aliases. It replaces self references with this and converts several functions to arrow functions to maintain the correct lexical context. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.