Skip to content

chore: replace join-path dependency with native path.join#532

Closed
gameroman wants to merge 2 commits into
firebase:masterfrom
gameroman:join-path
Closed

chore: replace join-path dependency with native path.join#532
gameroman wants to merge 2 commits into
firebase:masterfrom
gameroman:join-path

Conversation

@gameroman

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the join-path dependency and its associated sub-dependencies from the project, replacing its usage with the native Node.js path module in src/loaders/config-file.js and src/providers/fs.ts. I have no feedback to provide.

@wiz-9635d3485b

wiz-9635d3485b Bot commented Jul 5, 2026

Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings 1 Medium 1 Low
Software Management Finding Software Management Findings -
Total 1 Medium 1 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@bkendall

bkendall commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

There was something about this that has worried me in the past - maybe that it didn't work so well on Windows? I'll hopefully take a look at this in the next few days. Thanks!

@bkendall

bkendall commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Thanks again - I had to make a few more adjustments so I put it in another branch and just merged it all in (you still should get credit though!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants