replace join-path dependency with native path.join

[bkendall]

Mirror of #532 which will let all the tests run :)

Closes #532.

[wiz-9635d3485b]

Wiz Scan Summary

Scanner	Findings
Vulnerabilities	-
Sensitive Data	-
Secrets	-
IaC Misconfigurations	-
SAST Findings	1  1
Software Management Findings	-
Total	1  1

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

[gemini-code-assist]

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

[bkendall]

/gemini review

[gemini-code-assist]

Code Review

This pull request removes the external join-path dependency and replaces its usage with the native Node.js path module. Feedback recommends using path.resolve instead of path.join in the CLI to properly handle absolute paths, and removing a now-redundant ESLint disable comment in the file system provider.

[gemini-code-assist]

Since path.join is typed to return a string, the @typescript-eslint/no-unsafe-return lint rule is no longer violated here. We can remove the redundant eslint-disable-next-line comment.

To also prevent any potential @typescript-eslint/no-unsafe-argument warnings (since cwd is typed as any from options), we can explicitly cast cwd as a string.

Suggested change

	// eslint-disable-next-line @typescript-eslint/no-unsafe-return
	pathjoin(cwd, p, pathname),
	path.join(cwd, p, pathname),
	path.join(cwd as string, p, pathname),