fix: Move docker builds to native platforms - #22
Conversation
f80ffd3 to
9133e27
Compare
|
There are two temporary changes here that I will revert once I verify that this actually builds successfully.
|
69cdefe to
32a87fd
Compare
|
Swapped back to the original settings! If reviewers want to review the logs for the builds they are here: https://github.com/fanout/docker-pushpin/actions/runs/16948393367 |
|
After testing this we realized that this wouldn't build a single image with a combined manifest for the two cpu architectures, instead it would just push over whatever the first arch was. I misunderstood how Dockerhub handled this. Investigating on how to go back to a single image/manifest build without too much trouble. |
32a87fd to
0e4b563
Compare
|
Okay I finally have what I think is a winning actions file. When a git tag is pushed it produces the following artifacts (note the version values here are an example):
I've tested it here, but I'm not quite sure how to best test it for this context. I can turn off the latest flag, but if we test it in this PR it will create tags with the branch name instead of the version. Maybe we can merge with |
|
What's the issue with testing and If so merge with |
In the current incarnation of this, if we test and push a latest tag, we might have a bunch of people who are just pulling But yeah I think merging without latest here first and then turning it on in another small PR is the going recommendation. |
0e4b563 to
20c6f98
Compare
The current Docker builds are taking an excessively long time to complete, currently over 6 hours causing GitHub Actions to time out. We believe it's because internally it's using virtualization to build the arm64 version of the container. To attempt to alleviate this, this PR uses a GitHub Actions matrix to separate the builds into runners on their own native platforms. The hope is that the lack of needing to virtualize will speed up the overall time.
20c6f98 to
41a814f
Compare

The current Docker builds are taking an excessively long time to complete, currently over 6 hours causing GitHub Actions to time out. We believe it's because internally it's using virtualization to build the arm64 version of the container.
To attempt to alleviate this, this PR uses a GitHub Actions matrix to separate the builds into runners on their own native platforms.
The hope is that the lack of needing to virtualize will speed up the overall time.