Backport 16822 changes and dependencies#17240
Conversation
Signed-off-by: Amit Rastogi <amitrastogi2206@gmail.com>
|
Hi @amit-rastogi. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
We don't have to necessarily backport everything. I suggest to just try to implement WaitLeader in 3.5 and 3.4. |
|
Talked with the the amit-rastogi, he will not continue to work on this PR. |
This PR contains changes for backporting #16822 dependencies only.
Please refer to PR #17196 for backporting changes related to #16822.
With these changes "make test-unit" gives the following errors which would need additional changes-
All backporting changes in this PR have been confined to the tests/framework however, the below error related to clientv3.AuthConfig and cmd.ExpectWithContext would require changes outside the test framework like-
client/v3/config.go
pkg/expect/expect.go
This PR is to get feedback if making changes outside the test\framework for backporting should be feasible or alternatively, re-write\modify tests/e2e/v3_lease_no_proxy_test.go in v3.5 to use available v3.5 interface wherever feasible specially related to EtcdctlV3 and NewEtcdctl.